Fix: Cannot read properties of undefined (reading 'offsetHeight') (T1321478)#32692
Merged
ajivanyandev merged 6 commits intoDevExpress:25_2from Mar 12, 2026
Merged
Conversation
marker-dao
approved these changes
Mar 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a runtime crash in the internal animation positioning utilities when they are invoked with an empty renderer wrapper (e.g., when an element has been unmounted), which previously could attempt to read offsetHeight from undefined.
Changes:
- Removed a forced reflow access (
.offsetHeight) fromresetPositionto prevent crashing on empty wrappers. - Added an early return in
positionUtils.setupwhen the target element set is empty. - Added Jest coverage for the empty-wrapper scenarios in both
resetPositionandpositionUtils.setup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/common/core/animation/translator.ts | Removes the offsetHeight read that could crash when the wrapper is empty. |
| packages/devextreme/js/__internal/common/core/animation/translator.test.ts | Adds Jest tests asserting resetPosition doesn’t throw for empty/missing elements. |
| packages/devextreme/js/__internal/common/core/animation/m_position.ts | Returns undefined early when positioning is requested for an empty element set. |
| packages/devextreme/js/__internal/common/core/animation/m_position.test.ts | Adds Jest tests asserting setup returns undefined for empty/missing elements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.