List: Allow selection/highlighting of text in an item [QW] \ Implementation

[dmlvr]

No description provided.

[Copilot]

Pull request overview

This PR adjusts dxList swipe wiring to better support use cases like text selection within list items by removing the internal _swipeEnabled switch and only attaching swipe listeners when there is an onItemSwipe subscription. It also updates Scheduler tooltip list options/tests accordingly.

Changes:

• Removed the internal _swipeEnabled option from ListBase and stopped passing it from Scheduler tooltip list creation.
• Updated ListBase to attach swipe event handlers only when onItemSwipe is subscribed.
• Updated affected QUnit tests to reflect the new options shape (and attempted to update a swipe-related List test).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js	Updates a List swipe test (currently inconsistent with actual options/behavior).
packages/devextreme/testing/tests/DevExpress.ui.widgets.scheduler/desktopTooltip.tests.js	Updates assertions for Scheduler tooltip List options after removing _swipeEnabled.
packages/devextreme/js/__internal/ui/list/list.base.ts	Removes _swipeEnabled and changes swipe listener attachment to depend on action subscription.
packages/devextreme/js/__internal/scheduler/tooltip_strategies/m_tooltip_strategy_base.ts	Stops passing _swipeEnabled: false into tooltip List options.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

[pharret31]

are there any tests that checks resubscriptions in existing tests?

[dmlvr]

we have test which checks onItemSwipe subscription by on method

DevExtreme/packages/devextreme/testing/tests/DevExpress.ui.widgets/listParts/commonTests.js

Line 1164 in f6f41ab

QUnit.test('onItemSwipe - subscription by on method', function(assert) {

[EugeniyKiyashko]

 _attachSwipeEvent($itemElement: dxElementWrapper): void {
    // @ts-expect-error ts-error
    const endEventName = addNamespace(swipeEventEnd, this.NAME);
    eventsEngine.off($itemElement, endEventName);

    if (this.hasActionSubscription('onItemSwipe')) {
      eventsEngine.on($itemElement, endEventName, (e) => {
        this._itemSwipeEndHandler(e);
      });
    }
  }

  on(eventName: string | { [key: string]: Function }, eventHandler?: Function): this {
    const result = super.on(eventName, eventHandler);

    if (eventName === 'itemSwipe') {
      const $items = this._itemElements();

      this._attachSwipeEvent($items);
    }

    return result;
  }

  off(eventName: string, eventHandler?: Function): this {
    const result = super.off(eventName, eventHandler);

    if (eventName === 'itemSwipe') {
      const $items = this._itemElements();

      this._attachSwipeEvent($items);
    }

    return result;
  }