Skip to content

DataGrid: make showEditorAlways cell editable in new row (T1323684)#32845

Open
anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
anna-shakhova:26_1__T1323684_readonly_editor_new_row
Open

DataGrid: make showEditorAlways cell editable in new row (T1323684)#32845
anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
anna-shakhova:26_1__T1323684_readonly_editor_new_row

Conversation

@anna-shakhova
Copy link
Contributor

No description provided.

@anna-shakhova anna-shakhova self-assigned this Mar 10, 2026
Copilot AI review requested due to automatic review settings March 10, 2026 09:44
@anna-shakhova anna-shakhova requested a review from a team as a code owner March 10, 2026 09:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes DataGrid editing behavior so that showEditorAlways cells remain editable in newly inserted rows even when editing.allowUpdating is false, aligning getColumnTemplate logic with existing “new row can edit” behavior in click-to-edit handling.

Changes:

  • Adjusts EditingControllerImpl.getColumnTemplate to treat row.isNewRow as editable for showEditorAlways cells when allowAdding is used but allowUpdating is disabled.
  • Refactors readability of editability checks in getColumnTemplate (rowType/row state flags).
  • Adds TestCafe coverage for editable showEditorAlways editors and boolean editors in new rows, plus a regression check for existing rows remaining readonly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts Updates editor-template/editability gating to allow editing in inserted rows even when updating is disabled.
e2e/testcafe-devextreme/tests/dataGrid/common/editing/T1323684_readonlyEditorNewRow.ts Adds end-to-end regression tests covering the new-row editable behavior and existing-row readonly behavior.

@anna-shakhova anna-shakhova force-pushed the 26_1__T1323684_readonly_editor_new_row branch from ba4fda7 to 22920f0 Compare March 10, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants