DataGrid: make showEditorAlways cell editable in new row (T1323684)#32845
Open
anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
Open
DataGrid: make showEditorAlways cell editable in new row (T1323684)#32845anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
anna-shakhova wants to merge 1 commit intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes DataGrid editing behavior so that showEditorAlways cells remain editable in newly inserted rows even when editing.allowUpdating is false, aligning getColumnTemplate logic with existing “new row can edit” behavior in click-to-edit handling.
Changes:
- Adjusts
EditingControllerImpl.getColumnTemplateto treatrow.isNewRowas editable forshowEditorAlwayscells whenallowAddingis used butallowUpdatingis disabled. - Refactors readability of editability checks in
getColumnTemplate(rowType/row state flags). - Adds TestCafe coverage for editable
showEditorAlwayseditors and boolean editors in new rows, plus a regression check for existing rows remaining readonly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts | Updates editor-template/editability gating to allow editing in inserted rows even when updating is disabled. |
| e2e/testcafe-devextreme/tests/dataGrid/common/editing/T1323684_readonlyEditorNewRow.ts | Adds end-to-end regression tests covering the new-row editable behavior and existing-row readonly behavior. |
packages/devextreme/js/__internal/grids/grid_core/editing/m_editing.ts
Outdated
Show resolved
Hide resolved
…dating false (T1323684)
ba4fda7 to
22920f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.