chore: Log versions and locations when loading environment#1486
chore: Log versions and locations when loading environment#1486tpoliaw wants to merge 2 commits intolog-plan-registerfrom
Conversation
3bfa513 to
442e8db
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## log-plan-register #1486 +/- ##
==================================================
Coverage 95.23% 95.23%
==================================================
Files 43 43
Lines 3145 3151 +6
==================================================
+ Hits 2995 3001 +6
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could you please copy and paste a snippet of logging that that will output so i can see how it looks? |
|
Running with the system-test config |
Although I would rather have too much information than not enough, this is very verbose. When including the plans, we don't need the dodal version for every plan it uses because it would use the same dodal version? It only needs to be included once. I also think showing the full path is slight overkill because that is basically the same as the python import? For example I think the ideal logging would be something like this: These are probably the five most import things we need to know versions of to help find conflicts or behaviour changes (probably missed some). It would be good if it include either these important ones only (+ any others we can think of) or just log the version of every dependency in a list like a CI job does. My preference is probably just log every dependency to be honest and then we can very quickly check exactly what the server is using. Any thoughts on this though? |
|
I don't want to be hardcoding packages into blueapi logging. We can deduplicate the packages reported if it would be clearer but only packages included in the environment (as plans or devices) would be included. The idea of the path was to differentiate which packages were installed in the venv vs the scratch space. For a full version breakdown you can always use the |
|
Logging now reduced to single version report of each package being used for plans or devices |
oliwenmandiamond
left a comment
There was a problem hiding this comment.
Yes I think this is an improvement, thank you!
Second part of #1457