Skip to content

Fix vici valve names#2001

Open
jacob720 wants to merge 1 commit intomainfrom
fix_vici_valve_names
Open

Fix vici valve names#2001
jacob720 wants to merge 1 commit intomainfrom
fix_vici_valve_names

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

Updates vici valve names from the placeholders they were set to before. The correct names can be found with
caget -d31 BL21B-EA-GIR-01:VALVE1:POSN
caget -d31 BL21B-EA-GIR-01:VALVE2:POSN

Instructions to reviewer on how to test:

  1. Confirm names are correct

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner March 31, 2026 14:08
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.12%. Comparing base (af1430f) to head (4008491).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2001   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         319      319           
  Lines       12404    12404           
=======================================
  Hits        12295    12295           
  Misses        109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant