Skip to content

Diag table updates (#308)#319

Merged
gustavo-marques merged 4 commits intomainfrom
diag_table_updates_apr2026
Apr 10, 2026
Merged

Diag table updates (#308)#319
gustavo-marques merged 4 commits intomainfrom
diag_table_updates_apr2026

Conversation

@alperaltuntas
Copy link
Copy Markdown
Member

This PR adds the diag table changes listed in #308

Testing: GW_JRA.TL319_t232, B1850C_LTso.ne30_t232

@alperaltuntas
Copy link
Copy Markdown
Member Author

@iangrooms Just a quick note, I added hfibthermds to the native history file, which I assume is what you meant by hfidthermds.

@alperaltuntas
Copy link
Copy Markdown
Member Author

@iangrooms, I added BS_coeff_h and switched to using cmor names for those fields you listed (via the already existing visc_flds list).

@iangrooms & @gustavo-marques, while at it, should I also switch to the CMOR equivalent names of the following fields listed in diag_table.yaml?:

Field in diag_table.yaml CMOR equivalent Used in list(s)
sst_global tosga surface_flds_monthly
sss_global sosga surface_flds_monthly
C_P cpocean static_flds
Rho_0 rhozero static_flds
FrictWorkIntz dispkexyfo cmip7_native
diabatic_heat_tendency opottempdiff cmip7_z
diabatic_salt_tendency osaltdiff cmip7_z
Th_tendency opottemptend cmip7_z
Sh_tendency osalttend cmip7_z

@iangrooms
Copy link
Copy Markdown
Collaborator

@alperaltuntas yes, I think it would be good to switch the fields you mentioned to CMOR now, rather than having to rename them after the fact.

@gustavo-marques
Copy link
Copy Markdown
Collaborator

I agree, thank you for pointing out these fields.

@alperaltuntas
Copy link
Copy Markdown
Member Author

@iangrooms @gustavo-marques I made the all the changes, I think. This PR is ready for the next round of reviews.

Copy link
Copy Markdown
Collaborator

@iangrooms iangrooms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@gustavo-marques gustavo-marques merged commit 055a6cb into main Apr 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants