Enhance setmetatable() with generic type support

[alek13]

Add generic type annotation to setmetatable() function to avoid errors.
Now it possible to do like this:

--- @generic GenericCuboid: Voxrame.map.Cuboid
--- @param child_class GenericCuboid|nil
--- @return GenericCuboid
function Cuboid:extended(child_class)
	return setmetatable(child_class or {}, { __index = self })
end

[gemini-code-assist]

Summary of Changes

Hello @alek13, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the type definition for the setmetatable() function by introducing generic type parameters. This improvement allows the function to correctly infer and return the specific table type passed to it, thereby improving type safety and reducing potential type-related errors in Lua codebases that utilize static analysis tools like EmmyLua.

Highlights

• Generic Type Support for setmetatable(): Added generic type annotations to the setmetatable() function definition in global.lua. This allows for more precise type inference and prevents type-related errors when working with metatables, especially in scenarios like class extension.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• crates/emmylua_code_analysis/resources/std/global.lua
  • Added @generic T: table annotation to define a generic type T constrained to table.
  • Updated the @param table annotation to use the generic type T.
  • Updated the @return annotation to use the generic type T.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the EmmyLua type annotations for the setmetatable function by introducing generic type support. This change correctly preserves the type of the table passed as the first argument, which is a significant improvement for type inference, especially in object-oriented patterns where setmetatable is used for inheritance. The implementation is correct and follows standard practices for type annotations. This is a good improvement to the standard library definitions.