[Crate Limiter] Fix not limiting items due to wrong Item ID#151
Open
Infinitay wants to merge 5 commits intoEnriath:crate-limiterfrom
Open
[Crate Limiter] Fix not limiting items due to wrong Item ID#151Infinitay wants to merge 5 commits intoEnriath:crate-limiterfrom
Infinitay wants to merge 5 commits intoEnriath:crate-limiterfrom
Conversation
- MenuOptionClicked#getId wasn't returning the item ID when clicking on items in the inventory, you have to use MenuOptionClicked#getItemId instead. - RuneLite updated MenuOptionClicked and MenuEntry adding various item-related operations (runelite/runelite@c683e41)
- Fixed an issue where the event wouldn't be consumed for item ops which caused the plugin to not function properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
MenuOptionClickedevent wouldn't be consumed for item ops which caused the plugin to not function properly. For example, prior to these changes, players could spam clickSearchon Bird nests and this plugin wouldn't limit it according to the setTicks per itemconfig option. After these changes, the plugin behaves as intended.The main fix to use the appropriate item ID was simple. A while back, RL added item-related methods to
MenuOptionClickedandMenuEntrysuch as#getItemId. If we don't use this method, thengetIdwould be returning the wrong ID.Additional changes:
latest.releasegamevalAPI