Open
Conversation
mandryllo
requested changes
Apr 10, 2026
| export type Args = { | ||
| awsAccountId: string; | ||
| dataSourceName?: string; | ||
| stack: pulumi.Input<grafana.cloud.GetStackResult>; |
Collaborator
There was a problem hiding this comment.
Why inside Args and then omitted inside builder when using addAmp and others connections?
Can it be just under the same namespace but outside this type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces access policy token creation with all the required scopes that are currently needed and also removes the
GRAFANA_AUTHas a required env as it is now being created programmatically using service account resource. It also introduces a builderaddScopemethod so additional scopes can be provided.Required scope for the cloud access policy token is:
accesspolicies:read, accesspolicies:write, accesspolicies:delete, stacks:read, stack-service-accounts:write