Skip to content

refactor: migrate trivial components to TypeScript#7231

Open
kyle-ssg wants to merge 1 commit intomainfrom
refactor/migrate-simple-components
Open

refactor: migrate trivial components to TypeScript#7231
kyle-ssg wants to merge 1 commit intomainfrom
refactor/migrate-simple-components

Conversation

@kyle-ssg
Copy link
Copy Markdown
Member

@kyle-ssg kyle-ssg commented Apr 14, 2026

…pt FC

Remove all propTypes usage across the frontend codebase including global window assignments, ESLint globals, and per-component propTypes definitions. Remove direct prop-types dependency from package.json.

Convert 9 trivial class components to typed functional components: Flex, Column, NotFoundErrorPage, ErrorMessage, PasswordRequirements, SimpleTwoFactor/prompt, SimpleTwoFactor/index, TwoFactor, OrganisationSelect.

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Migrates some simple components to TypeScript

Password Requirements

image

ErrorMessage
image

Not Found Page

image

Radio

image

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kyle-ssg kyle-ssg requested a review from a team as a code owner April 14, 2026 13:06
@kyle-ssg kyle-ssg requested review from talissoncosta and removed request for a team April 14, 2026 13:06
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 14, 2026 1:06pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 14, 2026 1:06pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 14, 2026 1:06pm

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard refactor labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7231 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7231 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7231 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7231 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7231 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-7231 Finished ✅ Results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  20.4 seconds
commit  db1daf3
info  🔄 Run: #16030 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  28.7 seconds
commit  db1daf3
info  🔄 Run: #16030 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  58.9 seconds
commit  db1daf3
info  🔄 Run: #16030 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute, 5 seconds
commit  db1daf3
info  🔄 Run: #16030 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression

16 screenshots compared. See report for details.
View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant