Skip to content

refactor: migrate OrganisationSelect to TypeScript FC#7232

Open
kyle-ssg wants to merge 2 commits intomainfrom
refactor/migrate-organisation-select
Open

refactor: migrate OrganisationSelect to TypeScript FC#7232
kyle-ssg wants to merge 2 commits intomainfrom
refactor/migrate-organisation-select

Conversation

@kyle-ssg
Copy link
Copy Markdown
Member

@kyle-ssg kyle-ssg commented Apr 14, 2026

Replace AccountProvider with useGetOrganisationsQuery RTK hook. Accept a controlled value prop instead of reading from AccountStore. Move initial org selection logic to GitHubSetupPage.

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

  • Migrates organisation select to rtk + typescript / functional component
  • Improves props

How did you test this code?

Rendered an <OrganisationSelect on a page

@kyle-ssg @claude
refactor: migrate OrganisationSelect to TypeScript FC
1502810 
Replace AccountProvider with useGetOrganisationsQuery RTK hook.
Accept a controlled value prop instead of reading from AccountStore.
Move initial org selection logic to GitHubSetupPage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kyle-ssg kyle-ssg requested a review from a team as a code owner April 14, 2026 14:42
@kyle-ssg kyle-ssg requested review from Zaimwa9 and removed request for a team April 14, 2026 14:42
claude[bot]
claude bot reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Apr 14, 2026 3:03pm
flagsmith-frontend-staging Ready Ready Preview, Comment Apr 14, 2026 3:03pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Apr 14, 2026 3:03pm

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard refactor labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7232 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7232 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7232 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7232 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7232 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7232 Finished ✅ Results ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  6.8 seconds
commit  1502810
info  🔄 Run: #16032 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  57 seconds
commit  1502810
info  🔄 Run: #16032 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  59.9 seconds
commit  1502810
info  🔄 Run: #16032 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  46.8 seconds
commit  1502810
info  🔄 Run: #16032 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  20.3 seconds
commit  1f5a343
info  🔄 Run: #16034 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  51.7 seconds
commit  1f5a343
info  🔄 Run: #16034 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  1 minute, 2 seconds
commit  1f5a343
info  🔄 Run: #16034 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  46.5 seconds
commit  1f5a343
info  🔄 Run: #16034 (attempt 1)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

@kyle-ssg @claude
refactor: add className to OrganisationSelect and fix indentation
1f5a343 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9 Zaimwa9 is a code owner automatically assigned from Flagsmith/flagsmith-front-end

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

front-end Issue related to the React Front End Dashboard refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kyle-ssg