Skip to content

fix: Add visual divider between environment columns in comparison view #7250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
talissoncosta wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −12
Draft

fix: Add visual divider between environment columns in comparison view #7250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e9ab56
fix: add visual divider between environment columns in comparison view
talissoncosta Apr 15, 2026
04669d5
fix: move override icons next to toggle in condensed feature row
talissoncosta Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/web/components/CompareEnvironments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ class CompareEnvironments extends Component {
<FeatureRow
condensed
isCompareEnv
className='border-left-1 ps-2'
fadeEnabled={fadeEnabled}
fadeValue={fadeValue}
history={this.props.history}
Expand Down Expand Up @@ -390,7 +391,7 @@ class CompareEnvironments extends Component {
</div>
<Flex className='table-column'></Flex>
</Flex>
<Flex className='flex-row'>
<Flex className='flex-row border-left-1 ps-2'>
<div
className='table-column'
style={{ width: '80px' }}
Expand Down
21 changes: 10 additions & 11 deletions frontend/web/components/CondensedFeatureRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,17 +74,6 @@ const CondensedFeatureRow: React.FC<CondensedFeatureRowProps> = ({
</div>
<Flex className='table-column clickable'>
<Row>
<div
onClick={() => permission && !readOnly && editFeature()}
style={{ flex: 1 }}
className={`overflow-hidden ${fadeValue ? 'faded' : ''}`}
>
<FeatureValue
value={environmentFlags?.[id]?.feature_state_value ?? null}
data-test={`feature-value-${index}`}
/>
</div>

<SegmentOverridesIcon
onClick={(e) => {
e.stopPropagation()
Expand All @@ -100,6 +89,16 @@ const CondensedFeatureRow: React.FC<CondensedFeatureRowProps> = ({
count={projectFlag.num_identity_overrides}
showPlusIndicator={showPlusIndicator}
/>
<div
onClick={() => permission && !readOnly && editFeature()}
style={{ flex: 1 }}
className={`overflow-hidden ${fadeValue ? 'faded' : ''}`}
>
<FeatureValue
value={environmentFlags?.[id]?.feature_state_value ?? null}
data-test={`feature-value-${index}`}
/>
</div>
</Row>
</Flex>
</Flex>
Expand Down
Loading