Add claims parameter to authorize#1045
Draft
frereit wants to merge 3 commits intoFormidableLabs:mainfrom
Draft
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carbonrobot
reviewed
Dec 13, 2024
carbonrobot
reviewed
Dec 13, 2024
Contributor
carbonrobot
left a comment
There was a problem hiding this comment.
Thanks for the PR! Although we don't technically support Open ID Connect (OIDC), I can't see any reason not support this.
- Add support in AppAuth-iOS
- Documentation updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
setClaimsmethod of App Auth is not exposed. By adding a new keyclaimstoAuthConfig, similar toscopes, when it is set, we can callsetClaimson theAuthorizationRequest.Builderto add the requested claims to the authorization request.Steps to verify
Create a
AuthConfigurationthat requests some claims about the user:Then, use
authorizeto obtain an idToken, and verify that the requested claims are included in the token.Draft
This PR implements the
claimskey in theAuthConfigurationon the Android side. However, I do not own iOS devices and can therefore not implement this for iOS. I am opening this PR in the hopes that someone else completes it for the iOS side.