Fixed hasString and hasNumber for global and object arrays#1830
Open
manisto wants to merge 2 commits intoGDevelopApp:mainfrom
Open
Fixed hasString and hasNumber for global and object arrays#1830manisto wants to merge 2 commits intoGDevelopApp:mainfrom
manisto wants to merge 2 commits intoGDevelopApp:mainfrom
Conversation
Contributor
|
Thank you for the fix. Please increment the revision in the version. |
Contributor
|
Someone reported the issue and I forgot about this PR. I guess it's already fixed. |
Author
Looks like it. :-) It has the same changes, although it also appends a |
Contributor
|
It’s an action name. The one without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HasNumberandHasStringconditions for objects would always return true, regardless of whether the array contained the specified value or not. The reason was that the functions referenced a nonexistent variable named__ArrayTools.Temp.This PR removes all occurrences of this prefix, and now uses the extension scene variable simply named
Temp.An example project where the issue is documented has been attached to this PR.
ArrayToolsTest.zip