Detecting pointer behavior resolves data copying issues.#8901
Open
Chuan1937 wants to merge 2 commits intoGenericMappingTools:masterfrom
Open
Detecting pointer behavior resolves data copying issues.#8901Chuan1937 wants to merge 2 commits intoGenericMappingTools:masterfrom
Chuan1937 wants to merge 2 commits intoGenericMappingTools:masterfrom
Conversation
Member
Author
|
@seisman |
Contributor
|
I'll take a look at the other tests |
Member
|
No need to keep merging master in the PR branches. |
Contributor
|
I don't see any additional test failures relative to the upstream/master. |
Member
|
Messing with virtual files may have important impacts on the wrappers. Only them may test this as well. |
Member
|
This PR works well for PyGMT tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
gmtapi_import_grid(within theGMT_IS_REFERENCE|GMT_VIA_MATRIXbranch), check whether the data pointer has been redirected. If redirected, copy data row-by-row to the target location; otherwise, retain the original behavior.Fixes #8899