Only include instance methods once attr_encrypted is specified#1
Open
Only include instance methods once attr_encrypted is specified#1
Conversation
nightpool
force-pushed
the
isolate_instance_methods
branch
from
44bb329 to
5a83bc8
Compare
nightpool
commented
Jul 22, 2022
Member
Author
nightpool
left a comment
nightpool
left a comment
There was a problem hiding this comment.
we're already in the class context so if we go to the eigenclass then we'd be looking at class methods, not instance methods.
Member
Author
|
I also don't understand why singleton_class.class_eval worked in development, but not when |
Member
Author
|
Tests on the main-repo PR here: attr-encrypted#407 Tests fail on Rails 5+ due to https://gist.github.com/nightpool/14438c6765896054ea3a3eb1c66b1826. Tests fail on Rails 3-4 due to seemingly unrelated dependency/gem problems. |
Use the "InstanceMethods" module pattern to isolate the instance methods for attr_encrypted so that they don't infect other ActiveRecord models in the codebase. This resolves some compatibility issues with other libraries that override method_missing
nightpool
force-pushed
the
isolate_instance_methods
branch
from
bd44d90 to
84713fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the "InstanceMethods" module pattern to isolate the instance methods for attr_encrypted so that they don't infect other ActiveRecord models in the codebase. This resolves some compatibility issues with other libraries that override method_missing