Fix audio recording content stuck in 'held' state (XML) by VelikovPetar · Pull Request #6078 · GetStream/stream-chat-android

VelikovPetar · 2026-01-13T13:08:15Z

🎯 Goal

Deferring the IO operations done in the AudioRecordingController to the IO dispatcher (to resolve the StrictMode violations) introduced a race condition, where the MotionEvent.ACTION_UP is ignored, and the UI is not reset properly. (easily observable when the user taps the record button instead of holding it)

Merge after: #6077

🛠 Implementation details

Add detection for the intermediate state of the AudioRecordingController, where the startRecording method is suspended by the file creation, but the user cancels the started recording

🎨 UI Changes

Before	After
short_tap_xml_before.mp4	short_tap_xml_after.mp4

🧪 Testing

Open XML sample
Open channel
Quickly tap on record button
The snackbar info should be shown, not stuck in 'held' state

Summary by CodeRabbit

Bug Fixes
- Fixed audio recording content getting stuck in 'held' state.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…tart recording completes.

…rt recording completes.

…locked

github-actions · 2026-01-13T13:21:55Z

SDK Size Comparison 📏

SDK	Before	After	Status
stream-chat-android-client	5.25 MB	5.25 MB	🟢
stream-chat-android-offline	5.48 MB	5.48 MB	🟢
stream-chat-android-ui-components	10.62 MB	10.62 MB	🟢
stream-chat-android-compose	12.84 MB	12.84 MB	🟢

…held_xml # Conflicts: # CHANGELOG.md

coderabbitai · 2026-01-16T09:41:58Z

Walkthrough

Changes add a bug fix entry to the changelog regarding audio recording being stuck in a held state, and modify gesture event handling in the message composer to allow gesture-end actions (ACTION_UP/ACTION_CANCEL) to proceed during recording state transitions.

Changes

Cohort / File(s)	Summary
Documentation `CHANGELOG.md`	Added new Fixed entry documenting the audio recording held-state bug resolution.
Gesture Handling Logic `stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt`	Introduced conditional logic to permit gesture-end actions (ACTION_UP/ACTION_CANCEL) during in-progress recording transitions via `shouldAllowTransitionWindow` guard. Added `isGestureEndAction` and `isInRecordingTransition` checks; conditionally resets UI state when transition is active.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested reviewers

aleksandar-apostolov

Poem

🐰 A rabbit hops with glee today,
Gesture flows now find their way,
Recording transitions smooth and clear,
No more stuck states we need to fear—
The held state ghost has fled away! 🎙️✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: fixing audio recording content stuck in 'held' state, with (XML) indicating scope.
Description check	✅ Passed	Description includes Goal, Implementation details, UI Changes with before/after videos, and Testing steps. Contributor/Reviewer checklists are incomplete but core sections are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 252c414 and e326707.

📒 Files selected for processing (2)

CHANGELOG.md
stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{kt,kts}

📄 CodeRabbit inference engine (AGENTS.md)

Format and apply Kotlin style with Spotless (4 spaces, no wildcard imports, licence headers)

Files:

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt

**/*.kt

📄 CodeRabbit inference engine (AGENTS.md)

**/*.kt: Use @OptIn annotations explicitly; avoid suppressions unless documented
Document public APIs with KDoc, including thread expectations and state notes

Files:

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt

🧠 Learnings (5)

📓 Common learnings

Learnt from: CR
Repo: GetStream/stream-chat-android PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T15:00:07.506Z
Learning: Applies to **/stream-chat-android-ui-components/**/*Test.kt : Record Shot baselines when behaviour changes in XML kit UI tests

📚 Learning: 2025-12-17T15:00:07.506Z

Learnt from: CR
Repo: GetStream/stream-chat-android PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T15:00:07.506Z
Learning: Applies to **/stream-chat-android-ui-components/**/*Test.kt : Record Shot baselines when behaviour changes in XML kit UI tests

Applied to files:

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt

📚 Learning: 2025-12-17T15:00:07.506Z

Learnt from: CR
Repo: GetStream/stream-chat-android PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T15:00:07.506Z
Learning: Applies to **/stream-chat-android-compose/**/*.kt : Compose previews should use `StreamPreview` helpers

Applied to files:

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt

📚 Learning: 2025-12-17T15:00:07.506Z

Learnt from: CR
Repo: GetStream/stream-chat-android PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T15:00:07.506Z
Learning: Applies to **/stream-chat-android-compose/**/*Test.kt : Add Paparazzi snapshots for Compose UI regressions and run `verifyPaparazziDebug`

Applied to files:

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt

📚 Learning: 2025-12-17T15:00:07.506Z

Learnt from: CR
Repo: GetStream/stream-chat-android PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T15:00:07.506Z
Learning: Applies to **/stream-chat-android-compose/**/*.kt : Compose components should follow noun-based naming (e.g., `MessageList`, `ChannelListHeader`)

Applied to files:

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

GitHub Check: Test compose (2)
GitHub Check: Test compose (0)
GitHub Check: Test compose (1)
GitHub Check: base-android-ci / Run unit tests
GitHub Check: base-android-ci / Run static checks
GitHub Check: base-android-ci / Build
GitHub Check: compare-sdk-sizes / Compare SDK sizes

🔇 Additional comments (3)

CHANGELOG.md (1)

64-64: Changelog update looks good.

Entry is clear and matches the PR intent.

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/content/DefaultMessageComposerOverlappingContent.kt (2)

453-458: Good transition-window guard for end-of-gesture events.
This should prevent ACTION_UP/ACTION_CANCEL from being ignored while recording startup is still in flight.

541-559: Reset-on-transition for end actions looks correct.
Clearing UI when start is pending should avoid stuck “held” visuals while still triggering cancel/release paths.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…held_xml # Conflicts: # CHANGELOG.md

sonarqubecloud · 2026-01-20T08:27:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

VelikovPetar added 7 commits January 12, 2026 16:11

Fix race condition when cancel recording is called before the async s…

9d0865e

…tart recording completes.

Fix race condition when lock recording is called before the async sta…

26bb899

…rt recording completes.

Fix race condition when lock recording is called before the async sta…

c70b45a

…rt recording completes.

Merge branch 'develop' into bug/AND-954_fix_audio_recording_stuck_in_…

b22548a

…locked

Update CHANGELOG.md.

c680030

Fix audio recording content stuck in 'held' state.

f30da85

Update CHANGELOG.md.

44f0b61

Merge branch 'develop' into bug/AND-954_fix_audio_recording_stuck_in_…

e326707

…held_xml # Conflicts: # CHANGELOG.md

VelikovPetar marked this pull request as ready for review January 16, 2026 09:38

VelikovPetar requested a review from a team as a code owner January 16, 2026 09:38

gpunto approved these changes Jan 19, 2026

View reviewed changes

Merge branch 'develop' into bug/AND-954_fix_audio_recording_stuck_in_…

88c58b0

…held_xml # Conflicts: # CHANGELOG.md

VelikovPetar enabled auto-merge (squash) January 20, 2026 08:14

VelikovPetar merged commit 8dfb4df into develop Jan 20, 2026
14 checks passed

VelikovPetar deleted the bug/AND-954_fix_audio_recording_stuck_in_held_xml branch January 20, 2026 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix audio recording content stuck in 'held' state (XML)#6078

Fix audio recording content stuck in 'held' state (XML)#6078
VelikovPetar merged 9 commits intodevelopfrom
bug/AND-954_fix_audio_recording_stuck_in_held_xml

VelikovPetar commented Jan 13, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

github-actions bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 16, 2026

Uh oh!

sonarqubecloud bot commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

VelikovPetar commented Jan 13, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Goal

🛠 Implementation details

🎨 UI Changes

🧪 Testing

Summary by CodeRabbit

Uh oh!

github-actions bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Size Comparison 📏

Uh oh!

coderabbitai bot commented Jan 16, 2026

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

sonarqubecloud bot commented Jan 20, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

VelikovPetar commented Jan 13, 2026 •

edited by coderabbitai bot

Loading

github-actions bot commented Jan 13, 2026 •

edited

Loading