Conversation
package/src/components/ImageGallery/__tests__/ImageGalleryOverlay.test.tsx
Outdated
Show resolved
Hide resolved
SDK Size
|
package/src/components/ImageGallery/__tests__/ImageGalleryGridHandle.test.tsx
Outdated
Show resolved
Hide resolved
package/src/icons/ThreeDots.tsx
Outdated
| @@ -0,0 +1,16 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
We already have this icon. It's called MenuPointHorizontal
There was a problem hiding this comment.
Removed. I added it as per new designs but seems we don't have to include the action menu and the top right icon in this version so I forgot removing it
|
|
||
| import { IconProps } from './utils/base'; | ||
|
|
||
| export const ImageGrid = ({ height, width, ...rest }: IconProps) => ( |
There was a problem hiding this comment.
What is this supposed to be ? Don't get it
There was a problem hiding this comment.
This is used to show the Grid icon in the image gallery footer.
package/src/icons/MessageBubble.tsx
Outdated
|
|
||
| import { IconProps } from './utils/base'; | ||
|
|
||
| export const MessageBubble = ({ height, width, ...props }: IconProps) => ( |
There was a problem hiding this comment.
This too, it doesn't seem to be used anywhere
There was a problem hiding this comment.
Removed. I added it as per new designs but seems we don't have to include the action menu and the top right icon in this version so I forgot removing it
3 participants
This pull request refactors the
ImageGallerycomponent and related files to simplify customization, improve modularity, and update video/audio playback controls. The most significant changes include removing the legacyimageGalleryCustomComponentsprop in favor of explicit component overrides via context, updating the video and audio components to support playback rate, and cleaning up test files to match the new component API.ImageGallery Component Refactor and API Simplification
imageGalleryCustomComponentsprop and replaced it with explicit context-based overrides forImageGalleryHeader,ImageGalleryFooter,ImageGalleryVideoControls, andImageGalleryGrid, making customization more modular and clear. [1] [2]@gorhom/bottom-sheet, improving maintainability and reducing dependencies. [1] [2] [3]Video and Audio Component Updates
rate(playback speed) prop to both Expo and native video components, allowing control over video playback speed. [1] [2] [3] [4]PlayPauseButtonto use standardPlayandPauseicons instead ofNewPlayandNewPause, ensuring consistency in the UI. [1] [2]Test File Updates
ImageGalleryFooterto use default elements and removed tests for custom footer components, aligning tests with the new API.Code Cleanup
These changes make the image gallery and related components easier to customize, maintain, and test.