Skip to content

Conversation

@dhavalbhensdadiya-crest
Copy link

@dhavalbhensdadiya-crest dhavalbhensdadiya-crest commented Jan 22, 2026

Description

Added samples for below features in global and regional

  1. Bing tag to a secret
  2. List tags attached to a secret
  3. Delete tag from secret

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved (Note: This is based off feature/cmek-annotations)

…ion key and deleting annotations from the secret
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 22, 2026
@snippet-bot
Copy link

snippet-bot bot commented Jan 22, 2026

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: secretmanager Issues related to the Secret Manager API. label Jan 22, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Secret Manager Java samples by introducing new functionalities for managing secret tags, including binding, listing, and deleting them. It also adds samples for creating secrets encrypted with Customer-Managed Encryption Keys (CMEK) and for deleting secret annotations. These additions enhance the utility of the sample library for both global and regional Secret Manager operations, providing developers with comprehensive examples for advanced secret management.

Highlights

  • New Tag Operations Samples: Added comprehensive samples for binding, listing, and deleting tags associated with secrets, covering both global and regional Secret Manager resources.
  • Customer-Managed Encryption Key (CMEK) Samples: Introduced new samples demonstrating how to create secrets with Customer-Managed Encryption Keys (CMEK) for both global and regional secrets.
  • Delete Secret Annotations Samples: New samples have been added to illustrate the process of deleting annotations from existing secrets, applicable to both global and regional configurations.
  • README and Environment Variable Updates: The README has been updated to reflect new API enablement requirements (Cloud KMS API) and new environment variables for global and regional KMS keys, along with corresponding IAM permissions.
  • Expanded Integration Tests: New integration tests have been added to cover the newly introduced tag operations, CMEK secret creation, and annotation deletion functionalities for both global and regional secrets.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces new samples for managing tags on secrets, including binding, listing, and deleting tags, for both global and regional secrets. It also adds samples for creating secrets with Customer-Managed Encryption Keys (CMEK) and deleting secret annotations. The README.md has been updated to reflect the new API enablement and environment variables required for these samples. The corresponding integration tests have also been updated to cover the new functionalities. Overall, the new samples are a valuable addition, but there are critical issues with the main method signatures in some of the new Java files that will prevent them from compiling and running.

@dhavalbhensdadiya-crest dhavalbhensdadiya-crest force-pushed the feature/tags-bind-list-remove branch from bc6774f to 1751569 Compare January 22, 2026 07:23
@dhavalbhensdadiya-crest dhavalbhensdadiya-crest force-pushed the feature/tags-bind-list-remove branch from 1751569 to c335901 Compare January 22, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant