-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Added samples for tags operation on secret - bind, list, delete #10224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added samples for tags operation on secret - bind, list, delete #10224
Conversation
…ion key and deleting annotations from the secret
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary of ChangesHello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Secret Manager Java samples by introducing new functionalities for managing secret tags, including binding, listing, and deleting them. It also adds samples for creating secrets encrypted with Customer-Managed Encryption Keys (CMEK) and for deleting secret annotations. These additions enhance the utility of the sample library for both global and regional Secret Manager operations, providing developers with comprehensive examples for advanced secret management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces new samples for managing tags on secrets, including binding, listing, and deleting tags, for both global and regional secrets. It also adds samples for creating secrets with Customer-Managed Encryption Keys (CMEK) and deleting secret annotations. The README.md has been updated to reflect the new API enablement and environment variables required for these samples. The corresponding integration tests have also been updated to cover the new functionalities. Overall, the new samples are a valuable addition, but there are critical issues with the main method signatures in some of the new Java files that will prevent them from compiling and running.
secretmanager/src/main/java/secretmanager/CreateSecretWithCmek.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/DeleteSecretAnnotations.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/regionalsamples/CreateRegionalSecretWithCmek.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/regionalsamples/DeleteRegionalSecretAnnotations.java
Outdated
Show resolved
Hide resolved
bc6774f to
1751569
Compare
1751569 to
c335901
Compare
Description
Added samples for below features in global and regional
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only