Skip to content

Conversation

@dhavalbhensdadiya-crest
Copy link

@dhavalbhensdadiya-crest dhavalbhensdadiya-crest commented Jan 22, 2026

Description

Added samples for below operations in global and regional scope:

  1. Create secret with expiration
  2. Update secret with expiration
  3. Remove expiration from secret

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

…ion key and deleting annotations from the secret
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@snippet-bot
Copy link

snippet-bot bot commented Jan 22, 2026

Here is the summary of changes.

You are about to add 24 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: secretmanager Issues related to the Secret Manager API. labels Jan 22, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Google Secret Manager Java samples by introducing comprehensive examples for managing secret expiration, integrating with Customer-Managed Encryption Keys (CMEK), and handling resource tags. The new samples cover creation, modification, and deletion operations for secrets with expiration, creation of CMEK-protected secrets, and the full lifecycle of secret tags (bind, list, delete). These functionalities are demonstrated for both global and regional Secret Manager instances, ensuring broad applicability. The accompanying documentation and test suite have been updated to support these additions.

Highlights

  • Secret Expiration Samples: New Java samples have been added for creating, updating, and deleting Google Secret Manager secrets with defined expiration times, covering both global and regional scopes.
  • Customer-Managed Encryption Keys (CMEK) Samples: Samples demonstrating how to create secrets protected by Customer-Managed Encryption Keys (CMEK) are now available for both global and regional Secret Manager instances.
  • Secret Tag Management Samples: New samples have been introduced for binding, listing, and deleting tags associated with secrets, applicable to both global and regional resources.
  • Documentation Updates: The README.md has been updated to include instructions for enabling the Cloud KMS API and setting environment variables for global and regional KMS keys, along with required IAM permissions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new code samples for Secret Manager, including binding and deleting secret tags, creating secrets with CMEK and expiration, deleting secret annotations and expiration, listing secret tag bindings, and updating secret expiration. It also includes regional versions of these samples. The README.md file is updated to include instructions for enabling the Cloud KMS API and setting environment variables for KMS keys. Review comments suggest correcting the copyright year to 2024, fixing a string literal split across two lines, rephrasing "KMS Keys (Global and Regional)" for clarity, and making multi-line comments more concise.

Comment on lines +87 to +88
private static final String ANNOTATION_KEY =
"exampleannotationkey";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The string literal for ANNOTATION_KEY is incorrectly split across two lines. In Java, string literals must be on a single line unless concatenated.

  private static final String ANNOTATION_KEY = "exampleannotationkey";

@@ -0,0 +1,74 @@
/*
* Copyright 2026 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year 2026 appears to be a typo and should be 2024.

Suggested change
* Copyright 2026 Google LLC
* Copyright 2024 Google LLC

@@ -0,0 +1,66 @@
/*
* Copyright 2026 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year 2026 appears to be a typo and should be 2024.

Suggested change
* Copyright 2026 Google LLC
* Copyright 2024 Google LLC

Comment on lines +45 to +47
// Initialize client that will be used to send requests. This client only needs
// to be created
// once, and can be reused for multiple requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This multi-line comment can be made more concise to improve readability. It's generally better to keep comments on a single line if possible.

Suggested change
// Initialize client that will be used to send requests. This client only needs
// to be created
// once, and can be reused for multiple requests.
// Initialize client that will be used to send requests. This client only needs to be created
// once, and can be reused for multiple requests.

@@ -0,0 +1,77 @@
/*
* Copyright 2026 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year 2026 appears to be a typo and should be 2024.

Suggested change
* Copyright 2026 Google LLC
* Copyright 2024 Google LLC

@@ -0,0 +1,74 @@
/*
* Copyright 2026 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year 2026 appears to be a typo and should be 2024.

Suggested change
* Copyright 2026 Google LLC
* Copyright 2024 Google LLC

@@ -0,0 +1,66 @@
/*
* Copyright 2026 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year 2026 appears to be a typo and should be 2024.

Suggested change
* Copyright 2026 Google LLC
* Copyright 2024 Google LLC

@@ -0,0 +1,90 @@
/*
* Copyright 2026 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year 2026 appears to be a typo and should be 2024.

Suggested change
* Copyright 2026 Google LLC
* Copyright 2024 Google LLC

Comment on lines +55 to +56

// Initialize the client that will be used to send requests. This client only needs to be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This multi-line comment can be made more concise to improve readability. It's generally better to keep comments on a single line if possible.

Suggested change
// Initialize the client that will be used to send requests. This client only needs to be
// created once, and can be reused for multiple requests.

@@ -0,0 +1,64 @@
/*
* Copyright 2026 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The copyright year 2026 appears to be a typo and should be 2024.

Suggested change
* Copyright 2026 Google LLC
* Copyright 2024 Google LLC

@dhavalbhensdadiya-crest dhavalbhensdadiya-crest force-pushed the feature/expiration-create-update-delete branch from f5dfc54 to 15b8d11 Compare January 22, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant