-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(secretmanager): Added samples related to Secret Rotation #2186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(secretmanager): Added samples related to Secret Rotation #2186
Conversation
|
Here is the summary of changes. You are about to add 30 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Google Cloud Secret Manager PHP samples by introducing a wide array of new functionalities. It provides developers with practical examples for creating, updating, and managing secrets with advanced features such as time-to-live (TTL) expiration, customer-managed encryption keys (CMEK), and automated rotation policies. Furthermore, it includes samples demonstrating optimistic concurrency control using ETags for secret and secret version operations, and improved filtering capabilities for listing resources. These additions aim to streamline the development process for applications utilizing Secret Manager. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a comprehensive set of samples for Secret Manager's secret expiration and rotation features, covering both global and regional secrets. The additions include creating, updating, and removing these configurations, complete with corresponding tests. The code is well-organized and the changes are a valuable addition. I have identified a few minor areas for improvement concerning coding standards and a small error in the test files, which are detailed in the specific comments.
…with expiration TTL
…ts. Also fixed a typo in console message related to skipping cmek tests
…th rotation policies
23ec2b5 to
0406c72
Compare
As part of this feature, we have added global and regional samples for below features:
Please merge this PR once approved