-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix context menu blocking keyboard input after closing node graph #3571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Keavon
merged 12 commits into
GraphiteEditor:master
from
Ayush2k02:fix/close-context-menu-on-graph-overlay-close
Jan 24, 2026
Merged
Fix context menu blocking keyboard input after closing node graph #3571
Keavon
merged 12 commits into
GraphiteEditor:master
from
Ayush2k02:fix/close-context-menu-on-graph-overlay-close
Jan 24, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124235a to
a42cad8
Compare
Contributor
Author
|
Any updates on this guys ! |
Keavon
reviewed
Jan 20, 2026
Keavon
reviewed
Jan 20, 2026
Contributor
Author
|
Done , I believe this is what you meant @Keavon in this discord discussion here |
Contributor
Author
Screen.Recording.2026-01-24.at.3.19.50.PM.mov |
Contributor
Author
|
Fixed the issue, this one is now good to review from my side |
Keavon
reviewed
Jan 24, 2026
Member
|
!build |
|
Keavon
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE ( Nothing happens when the user click delete after the whole flow )
Screen.Recording.2026-01-12.at.6.21.19.AM.mov
AFTER ( Delete and other operations working now )
Screen.Recording.2026-01-04.at.10.28.36.AM.mov
Simple enough fix which passes
nodegraphtocreateDocumentStateand callcloseContextMenuwhen the user shifts to the artboard from node graphCloses #3559