Skip to content

Expose the secondary input for Logical And and Or nodes#3711

Merged
TrueDoctor merged 2 commits intoGraphiteEditor:masterfrom
he1senbrg:fix-secondary-input
Feb 3, 2026
Merged

Expose the secondary input for Logical And and Or nodes#3711
TrueDoctor merged 2 commits intoGraphiteEditor:masterfrom
he1senbrg:fix-secondary-input

Conversation

@he1senbrg
Copy link
Contributor

@he1senbrg he1senbrg commented Feb 2, 2026

@he1senbrg he1senbrg marked this pull request as draft February 2, 2026 13:21
@he1senbrg he1senbrg marked this pull request as ready for review February 2, 2026 13:32
@he1senbrg he1senbrg force-pushed the fix-secondary-input branch from e89d2f5 to cfc5d1f Compare February 2, 2026 13:33
@TrueDoctor
Copy link
Member

Could you also add this for other logic nodes where having a non exposed parameter obviously does not make sense (e.g. the or node)?

@he1senbrg he1senbrg force-pushed the fix-secondary-input branch from cfc5d1f to 7ed4676 Compare February 2, 2026 15:40
@he1senbrg
Copy link
Contributor Author

I have exposed the other logic nodes. In retrospect it was dumb of me not to do that, lol.

logical_nodes

@he1senbrg he1senbrg changed the title Expose the secondary input for Logical And node Expose the secondary input for Logical nodes Feb 2, 2026
@Keavon
Copy link
Member

Keavon commented Feb 2, 2026

This is not desired on any nodes except AND and OR.

@he1senbrg he1senbrg force-pushed the fix-secondary-input branch 2 times, most recently from 66f9546 to b2c73fa Compare February 3, 2026 01:11
@he1senbrg he1senbrg marked this pull request as draft February 3, 2026 01:15
@he1senbrg he1senbrg force-pushed the fix-secondary-input branch from b2c73fa to b7cfeff Compare February 3, 2026 01:22
@he1senbrg he1senbrg force-pushed the fix-secondary-input branch from b7cfeff to da7d53d Compare February 3, 2026 01:24
@he1senbrg
Copy link
Contributor Author

Okay got it, I have updated it.

update

@he1senbrg he1senbrg marked this pull request as ready for review February 3, 2026 01:29
@he1senbrg he1senbrg changed the title Expose the secondary input for Logical nodes Expose the secondary input for Logical And and Or nodes Feb 3, 2026
@TrueDoctor TrueDoctor enabled auto-merge (squash) February 3, 2026 12:25
@TrueDoctor TrueDoctor merged commit 7e436f4 into GraphiteEditor:master Feb 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants