feat - Issue 98, implementing remaining controller functionality #115
Open
springframeworkguru wants to merge 2 commits intoGreenButtonAlliance:mainfrom
Open
feat - Issue 98, implementing remaining controller functionality #115springframeworkguru wants to merge 2 commits intoGreenButtonAlliance:mainfrom
springframeworkguru wants to merge 2 commits intoGreenButtonAlliance:mainfrom
Conversation
…hods; add corresponding tests. Update controllers to leverage `ApiRequestValidator`. Introduce new test classes for `BatchController` and `IntervalBlockController`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the DTO export and mapping services in the Green Button Alliance codebase. The main focus is on expanding support for Atom feeds and entries for various domain entities, improving DTO mapping, and adding a new DTO for service status. The changes improve modularity, extensibility, and clarity in how domain objects are exposed as DTOs and Atom feeds.
Closes #98
Key changes include:
Atom Feed and Entry Export Enhancements
Added multiple new methods to the
DtoExportServiceand its implementations (DtoExportServiceFacadeandDtoExportServiceImpl) to support Atom feed and entry creation forUsagePoint,TimeConfiguration,RetailCustomer,UsageSummary,ReadingType, andServiceStatusentities. This includes feed creation by entity lists or IDs, and entry creation by entity or ID. [1] [2] [3]Introduced a new method in
BaseExportServiceto create an Atom entry for the service status, wrapping a newServiceStatusDto.DTO and Mapper Improvements
Added a new DTO:
ServiceStatusDto, representing the service status with JAXB annotations for XML serialization.Extended the
CustomerMapperinterface to include a default method for mapping aRetailCustomerEntityto aCustomerDto, including nested mapping for organization, email, and phone details.Repository and Service Interface Updates
ReadingTypeServiceinterface to add afindAll()method for retrieving all reading types.Dependency and Constructor Updates
DtoExportServiceFacadeandDtoExportServiceImplto inject and use the new repositories and mappers required for the enhanced export and mapping functionality. [1] [2]Import Cleanups
References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]