add onSelectionChange and persist selectedRowIds across pages#508
Merged
joellanciaux merged 1 commit intoGriddleGriddle:masterfrom Nov 8, 2016
tim-phillips:onSelectionChange
Merged
add onSelectionChange and persist selectedRowIds across pages#508joellanciaux merged 1 commit intoGriddleGriddle:masterfrom tim-phillips:onSelectionChange
joellanciaux merged 1 commit intoGriddleGriddle:masterfrom
tim-phillips:onSelectionChange
Conversation
Author
Member
|
Thanks so much - one of us will test it out a bit more and try to get things merged + published today / tomorrow. |
Member
|
Thank you for putting this together! 👍 |
Author
|
You got it! |
|
Is there documentation on how to implement this when using griddles? I don't see any references to checkboxes in the documentation. Note: I saw current documentation is v0, does that mean these changes have been merged but not released? |
Contributor
|
I never worked with Griddle 0.x, so I can't speak to this feature, but this appears to be part of v0.8.2 (#809). As far as I know v1 doesn't have an equivalent feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented an onSelectionChange callback that the user can use. I needed it for a project of mine and couldn't figure out how to get Griddle 1.0 working, so here are my changes.
A number of these changes are cosmetic, the formatting in the existing multiple selection code was pretty inconsistent.
I don't know why my
.jsfiles are so much longer than other peoples' changes, but this is what I got when I built with grunt.Please let me know if you have any questions or issues with these commits.