Skip to content

Support structured matrices#13

Merged
timholy merged 2 commits intomainfrom
teh/structured
Mar 10, 2026
Merged

Support structured matrices#13
timholy merged 2 commits intomainfrom
teh/structured

Conversation

@timholy
Copy link
Member

@timholy timholy commented Mar 10, 2026

These two commits support SparseMatrixCSC and "PlusMinus1Banded" matrices (Tridiagonal etc).

timholy and others added 2 commits March 10, 2026 11:00
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- src/structured.jl: Diagonal (exact analytic) and a unified
  PlusMinus1Banded implementation (SymTridiagonal, Bidiagonal,
  Tridiagonal) using A[i,i]/A[i,i+1]/A[i+1,i] indexing so structural
  zeros are skipped cheaply.  symcover/symdiagcover accept any
  PlusMinus1Banded so callers can use a symmetric-valued Tridiagonal.
- src/covers.jl: Adjoint/Transpose wrappers that unwrap the parent and
  swap cover dimensions.
- test/runtests.jl: tests for all of the above.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@timholy timholy merged commit ce4a3f2 into main Mar 10, 2026
3 checks passed
@timholy timholy deleted the teh/structured branch March 10, 2026 16:12
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 89.73064% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.84%. Comparing base (65ca2c5) to head (88dd531).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ext/SIASparseArrays.jl 87.07% 42 Missing ⚠️
src/structured.jl 94.86% 13 Missing ⚠️
src/covers.jl 62.50% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #13      +/-   ##
===========================================
- Coverage   100.00%   92.84%   -7.16%     
===========================================
  Files            3        5       +2     
  Lines          258      852     +594     
===========================================
+ Hits           258      791     +533     
- Misses           0       61      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant