fix(Grid): Add border to rendered height calc.#16906
Open
MayaKirova wants to merge 4 commits intomasterfrom
Open
fix(Grid): Add border to rendered height calc.#16906MayaKirova wants to merge 4 commits intomasterfrom
MayaKirova wants to merge 4 commits intomasterfrom
Conversation
MayaKirova
added
❌ status: awaiting-test
IMinchev64
previously approved these changes
Feb 19, 2026
Contributor
|
@MayaKirova please add a pr for 21.1.x |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an IgxGrid auto-sizing bug where applying a CSS border (with width/height: 100%) could lead to incorrect rendered height calculations and continuous growth.
Changes:
- Updates the grid body height calculation to include the host element’s top/bottom border widths.
- Avoids duplicate
getComputedStyle(...)calls by caching computed styles. - Updates the auto-size sample styling to apply a border to
igx-grid(repro for the issue).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/app/grid-auto-size/grid-auto-size.sample.scss | Adds a border style to the sample grid to reproduce/validate the fix visually. |
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Includes border widths in rendered height calculation to prevent incorrect percent-height sizing behavior. |
projects/igniteui-angular/grids/grid/src/grid-base.directive.ts
Outdated
Show resolved
Hide resolved
dkamburov
added
✅ status: verified
Member
|
@MayaKirova , could you please resolve the copilot comments and open a pr to 21.1.x too? (think it's missing for this bugfix) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MayaKirova
added
❌ status: awaiting-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16640
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)