feat(grids/filtering): Add percent representation hint to filter inputs for percent columns#17083
Draft
feat(grids/filtering): Add percent representation hint to filter inputs for percent columns#17083
Conversation
…g for percent columns Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com> Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/b546a4e6-6867-4617-ad80-073cc007b26d
… filter row Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com> Agent-Logs-Url: https://github.com/IgniteUI/igniteui-angular/sessions/b546a4e6-6867-4617-ad80-073cc007b26d
Copilot
AI
changed the title
[WIP] Fix unclear percent filtering representation in UI
feat(grids/filtering): Add percent representation hint to filter inputs for percent columns
Mar 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves filtering UX for percent-type grid columns by adding a live “percent representation” hint (e.g. 0.03 → 3%) in both the filter row and the Excel-style custom filter dialog, aligning the experience with the existing cell editor behavior.
Changes:
- Add a percent preview suffix hint in the filter row input and in the Excel-style custom filter dialog input for percent columns.
- Fix the filter-row input
typegetter to correctly handlePercentand ensure the appropriate formatter pipe is available to templates. - Add tests covering the percent hint rendering behavior in both UIs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/column.spec.ts | Adds tests asserting the percent hint suffix appears only when a value is provided (filter row + ESF custom dialog). |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-default-expression.component.ts | Imports IgxSuffixDirective and IgxPercentFormatterPipe to support rendering a percent hint suffix in the ESF custom dialog. |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-default-expression.component.html | Renders the conditional percent hint suffix for percent columns when searchVal is set. |
| projects/igniteui-angular/grids/core/src/filtering/base/grid-filtering-row.component.ts | Adds Percent handling to input type getter and imports IgxPercentFormatterPipe for the template. |
| projects/igniteui-angular/grids/core/src/filtering/base/grid-filtering-row.component.html | Renders the percent hint span within the suffix area when filtering a percent column and a value is present. |
| package.json | Adds node-releases as a direct devDependency. |
| package-lock.json | Updates lockfile to reflect dependency changes (including node-releases and other npm resolution churn). |
Comment on lines
+861
to
+864
| // Enter a value to trigger the suffix (350ms debounce is applied to the filter row input) | ||
| GridFunctions.typeValueInFilterRowInput(0.03, fix, input); | ||
| tick(350); | ||
| fix.detectChanges(); |
There was a problem hiding this comment.
This test hard-codes the filter-row debounce duration (350ms). Since the debounce is defined by INPUT_DEBOUNCE_TIME in the component, consider referencing that exported token’s factory value (or a shared constant used in tests) to avoid brittle failures if the debounce time changes in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filtering a
percent-type column, the input gives no indication of whether the user should enter the raw underlying value (0.03) or the display percentage (3). The cell editor already shows a live percent preview suffix — this brings the same UX to the filter row and the Excel-style filter custom dialog.Changes
grid-filtering-row.component.tsPercentcase intypegetter (was returningundefined, leaving the input without atypeattribute)IgxPercentFormatterPipeto component importsgrid-filtering-row.component.htmlpercentand a value is present, renders a<span class="igx-grid__filtering-row-percent-hint">inside the suffix showing the typed value formatted as a percentage (e.g.0.03→3%)excel-style-default-expression.component.ts / .htmlIgxSuffixDirective+IgxPercentFormatterPipeto importssearchValis setcolumn.spec.tsThe hint mirrors what the cell editor already shows:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5005 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44524039 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5881548494751122789,9020479793249870160,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,14794112411320260731,5892079242632477046,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5003 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-61884147 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15645166211072150218,11605460742287624889,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12108632259767633110,17344837188505846502,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome --user-data-dir=/tmp/karma-44524039 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=44524039 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)android.clients.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=6286 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-97485483 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9854082182616735546,13678260469158639640,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16015504881944042256,17532224460988987701,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome --user-data-dir=/tmp/karma-97485483 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=97485483 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)clients2.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5005 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44524039 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5881548494751122789,9020479793249870160,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,14794112411320260731,5892079242632477046,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5004 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81516743 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,11109773833415926646,15267211610726191680,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,4426389747823820436,15682720818887519377,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5003 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-61884147 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15645166211072150218,11605460742287624889,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12108632259767633110,17344837188505846502,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)content-autofill.googleapis.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=6278 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-56702612 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,6329673334288820058,9412723425518903040,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12562857759879053444,8746962202129281808,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome --user-data-dir=/tmp/karma-56702612 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=56702612 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=6286 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-97485483 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,9854082182616735546,13678260469158639640,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,16015504881944042256,17532224460988987701,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)redirector.gvt1.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5005 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44524039 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5881548494751122789,9020479793249870160,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,14794112411320260731,5892079242632477046,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome --user-data-dir=/tmp/karma-44524039 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=44524039 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5004 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-81516743 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,11109773833415926646,15267211610726191680,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,4426389747823820436,15682720818887519377,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)www.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5005 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-44524039 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,5881548494751122789,9020479793249870160,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,14794112411320260731,5892079242632477046,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5003 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-61884147 --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,15645166211072150218,11605460742287624889,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12108632259767633110,17344837188505846502,4 --trace-process-track-uuid=3190708989122997041 bash(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-146.0.7680.153/chrome-linux64/chrome --user-data-dir=/tmp/karma-44524039 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox --disable-gpu --window-size=820,800 --js-flags=--expose-gc http://localhost:9876/?id=44524039 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.