Use OpenMP for threading instead of TBB#171
Merged
ndgrigorian merged 6 commits intomainfrom Mar 14, 2026
Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
OpenMP implicitly needs to be found by MKL with "intel_thread" set, so the set is unnecessary
This was referenced Mar 11, 2026
Merged
antonwolfy
reviewed
Mar 12, 2026
antonwolfy
previously approved these changes
Mar 14, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Since the performance measurements (done through npbench) proves no impact, LGTM!
The only minor nit below.
Thank you @ndgrigorian for resolving the issue with crash.
antonwolfy
approved these changes
Mar 14, 2026
ndgrigorian
added a commit
that referenced
this pull request
Mar 18, 2026
ndgrigorian
added a commit
that referenced
this pull request
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes moving from TBB to OpenMP threading due to observed segfaults in the Python interpreter teardown when using TBB, likely from having multiple threading frameworks installed simultaneously when using PyPI NumPy