Open
Conversation
pebeto
force-pushed
the
48-artifact_location-default-is-not-being-set
branch
from
8df955f to
5b2141e
Compare
ablaom
reviewed
May 28, 2024
|
|
||
| @testset "logartifact_error" begin | ||
| @test_broken logartifact(mlf, r, "/etc/shadow") | ||
| @test_broken logartifact(mlf, r, "/etc/misina") |
Member
There was a problem hiding this comment.
Shouldn't this be a @test_throws ? Usually @test_broken is for temporarilydisabling tests that are failing but which we hope to rectify in the near future.
ablaom
reviewed
May 28, 2024
| open(tempfilename, "w") do file | ||
| write(file, "Hello, world!\n") | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
I think it is more usual to use the functions tempname or tempdir to create temporary files during CI, although I think this still works. But perhaps you have reasons for doing it this way?
ablaom
approved these changes
May 28, 2024
Member
There was a problem hiding this comment.
I'm not familiar enough with the code base to comment on whether this is the best remedy, but it looks good to me. Hopefully @deyandyankov can chime in.
I haven't looked at the CI failure.
Thanks for prompt attention to this issue 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48
In this PR, I'm fixing a design issue inherited from the original
mlflowplatform. In this case, when someone instantiates an experiment with default values, instead of letting the server set theartifact_location, we are setting it as./mlrunsto avoid non-absolute directories (breaking logging artifacts).