Add store-like method for atomic_add#97
Closed
AntonOresten wants to merge 5 commits intoJuliaGPU:mainfrom
Closed
Conversation
AntonOresten
changed the title
store-like method for atomic_add
Contributor
Author
|
Requires rewriting due to changes in #96. Still not clear what the ideal interface is. Tile-space atomics feels generally useful at least, and one that users shouldn't need to define themselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tile-space indexing for
atomic_add, matchingstore's (array, index, tile) signature. This lets users swap between them without changing indexing logic. Perhaps this deserves its own function likeatomic_store_add, but the method signature is unambiguous enough and not too far from the other explicitly tile-indexed methods.Depends on #96
Closes #50