break handlers.jl into default_render, default_equality and preprocess#37
Conversation
johnnychen94
changed the title
handlers.jl into default_render, default_equality and preprocess
src/core.jl
Outdated
| actual::T, | ||
| rendermode::Union{RenderMode, Nothing}=nothing, | ||
| equiv::Union{Function, Nothing}=nothing; | ||
| kw...) where T |
There was a problem hiding this comment.
Arguments order is changed because I made rendermode and equiv optional.
kw... are all passed to preprocess as it was (the only possible kw here is size for image type). It might be changed in the future, so I didn't document it.
|
What is the motivation of moving all this code out of its own file and intio From the title I thought it was going to turn Aside: moving code and editting code makes for hard to follow diffs. |
I'm planing to move |
|
@oxinabox I've tried to minimize the differences for you to review. Since all codes in It comes to an end of my vacation, I need to focus on my school stuff first and then I'll come back continue it. Since you prefer holding things apart in separate files, I'll move things related to After this PR:
|
|
mind to take a look at it? 👀@oxinabox |
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
I like it.
Just a few minor things
|
The last three commits do a trivial organization work breaking |
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
Nice
Bump the version (this is not breaking right? So patch)
and merge when ready,
then tag a release
_convert To avoid code duplication, codes in `handler.jl` are broken down into three functions: * `default_rendermode` that infers the most appropriate render mode according to DataFormat and type of `actual` * `default_equality` that infers the suitable equality compare method. * `_convert` that converts `actual` so that it has the same type of `reference`.
3 participants
This PR is a part of #36 that makes the overall pipeline cleaner. It's also a preparation for the introduction of
@test_reference_brokenand@test_reference_skip.To avoid code duplication, codes in
handler.jlare broken down into three functions:default_renderthat infers the most appropriate render mode according to types offilenameandactual. By default, it'sBeforeAfterFull().default_equalitythat infers the suitable equality compare method. By default, it'sisequal.preprocessthat makesactualhave the same type ofreference.