fix:[#1046] Sub Row Selection not working correctly#1049
Open
vzanimonets wants to merge 1 commit intoKevinVandy:v2from
Open
fix:[#1046] Sub Row Selection not working correctly#1049vzanimonets wants to merge 1 commit intoKevinVandy:v2from
vzanimonets wants to merge 1 commit intoKevinVandy:v2from
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
This is a bit confusing to me. I don't see the bug yet in the storybook stories I have set up. Let's create one. Also, the logic seems to be accounting for sub-row selection in multiple places now with this change. Guessing this can be simplified. |
The problem is also described in this open issue: #1247 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, after selecting all subrows by clicking on the group header, deselecting individual subrows will correctly update the group header's checkbox status.