feat(credits): add CLAWNYC promo code#1089
Open
kilo-code-bot[bot] wants to merge 1 commit intomainfrom
Open
Conversation
| }, | ||
| { | ||
| // TODO: re-encrypt with production key: pnpm promo encrypt CLAWNYC | ||
| encrypted_credit_category: 'BQvtkd104X5pIN+mKn21Tw==:PLQKIZGhb19EG21tRBjV7w==:0MmIBfnr3g==', |
Contributor
Author
There was a problem hiding this comment.
CRITICAL: This promo is encrypted with the wrong key and will fail to load in production
encryptedSelfServicePromos is decrypted eagerly when this module is imported. Because this ciphertext is still marked for re-encryption with the production key, decryptPromoCode(encrypted_credit_category) will throw under the production CREDIT_CATEGORIES_ENCRYPTION_KEY, which can break promo loading at startup.
Contributor
Author
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)None. Fix these issues in Kilo Cloud Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 149,662 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAWNYCwith $10 credit value and 2,000 max redemptionsencryptedSelfServicePromosfollowing the existing patternencrypted_credit_categoryvalue must be re-encrypted with the productionCREDIT_CATEGORIES_ENCRYPTION_KEYby runningpnpm promo encrypt CLAWNYCand updating the valueVerification
pnpm typecheck— passesprettier --write— no formatting changes neededSelfServicePromoCreditCategoryConfigtype requirements (is_user_selfservicable: true,is_idempotent: true,total_redemptions_allowed,amount_usd)Visual Changes
N/A
Reviewer Notes
encrypted_credit_categoryis a placeholder encrypted with a temporary key. Before merging, a team member with access to the productionCREDIT_CATEGORIES_ENCRYPTION_KEYmust runpnpm promo encrypt CLAWNYCand replace the value. This follows the same workflow seen in commitsaacccb3f→191eabf6.customer_requirementis set, making this redeemable by any user.promotion_ends_atorexpiry_hoursis set — add these if the promo should have a time limit.Built for Brendan by Kilo for Slack