fix: exit with error code when CLI filepath does not exist#17
Open
mattdawkins wants to merge 1 commit intoKitware:mainfrom
Open
fix: exit with error code when CLI filepath does not exist#17mattdawkins wants to merge 1 commit intoKitware:mainfrom
mattdawkins wants to merge 1 commit intoKitware:mainfrom
Conversation
pipeline_filepath_validator called ctx.exit() which exits with code 0 (success) when the input file does not exist. Use click.BadParameter instead, which prints a proper error message and exits with a non-zero status code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx.exit()withraise click.BadParameter(...)inpipeline_filepath_validatorbatbot pipelinewould silently exit with code 0 (success), making it impossible for scripts or CI to detect the failureclick.BadParameterprints a proper error message with usage hints and exits with a non-zero statusTest plan
batbot pipeline nonexistent.wavand verify it exits with a non-zero code and a clear error message🤖 Generated with Claude Code