Draft
Conversation
This makes `db.iterator()` with buffer encoding as fast as an iterator with utf8 encoding. The approach is: 1. In each `nextv()` call, create a `std::vector<char>` to hold the raw data of multiple entries 2. Copy LevelDB slices directly into that vector with `memcpy()` 3. Create an ArrayBuffer backed by the vector 4. In JS, split it into Buffers, each backed by the same ArrayBuffer but using a different offset. Apart from this being an incomplete implementation (it makes utf8 slower because the C++ side is buffer-only meaning JS has to transcode buffer to utf8), the approach has a downside: if userland code keeps a reference to just one of the Buffers, the entire ArrayBuffer is kept alive too. I.e. it costs memory. For now this PR is just a reference. The ideal solution (for this particular bottleneck) sits somewhere in between. For example, I might take just the ArrayBuffer concept, to replace use of `napi_create_buffer_copy()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
db.iterator()with buffer encoding as fast as an iterator with utf8 encoding. The approach is:nextv()call, create astd::vector<char>to hold the raw data of multiple entriesmemcpy()Apart from this being an incomplete implementation (it makes utf8 slower because the C++ side is buffer-only meaning JS has to transcode buffer to utf8), the approach has a downside: if userland code keeps a reference to just one of the Buffers, the entire ArrayBuffer is kept alive too. I.e. it costs memory.
For now this PR is just a reference. The ideal solution (for this particular bottleneck) sits somewhere in between. For example, I might take just the ArrayBuffer concept, to replace use of
napi_create_buffer_copy().