openpdf-renderer - formatting according to checkstyle rules (no tabs) #1527
Open
stomaszek wants to merge 1 commit intoLibrePDF:masterfrom
Open
openpdf-renderer - formatting according to checkstyle rules (no tabs) #1527stomaszek wants to merge 1 commit intoLibrePDF:masterfrom
stomaszek wants to merge 1 commit intoLibrePDF:masterfrom
Conversation
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 23 medium |
| Documentation | 10 minor |
| CodeStyle | 63 minor |
| Complexity | 4 medium |
🟢 Metrics 0 complexity . 2 duplication
Metric Results Complexity 0 Duplication 2
TIP This summary will be updated as you push new changes. Give us feedback
stomaszek
changed the title
Author
|
Codacy is detecting new issues, but all of them existed before just appear in changed lines - I hope it is not blocking merge. If so I can try to resolve Codacy findings, but better do it in following smaller PRs instead one big bang fix of 9k+ checkstyle violations in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
Code reformatted according to defined checkstyle - no tabs used
Next checkstyle rules in following PR to keep PR smaller and easier to review/merge
Related Issue: #
Unit-Tests for the new Feature/Bugfix
none
Compatibilities Issues
None
Your real name
Sławomir Tomaszek
Testing details
none