fix(linux/kms): skip NVIDIA cards for VAAPI on hybrid GPU laptops#4473
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds logic to skip NVIDIA graphics cards when searching for VAAPI-capable devices in KMS (Kernel Mode Setting) display capture. This is particularly important for hybrid GPU laptops where the display may be connected through an NVIDIA GPU but hardware encoding should occur on the Intel/AMD GPU that supports VAAPI.
Key Changes
- Added NVIDIA card filtering for VAAPI device enumeration in two critical locations within kmsgrab.cpp
- The filtering occurs during both display initialization and display name enumeration
- Debug logging added to track when NVIDIA cards are being skipped for VAAPI
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
70a1b64 to
9f0aefb
Compare
e66337d to
9218612
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4473 +/- ##
=========================================
Coverage ? 15.39%
=========================================
Files ? 94
Lines ? 19178
Branches ? 8861
=========================================
Hits ? 2952
Misses ? 14930
Partials ? 1296
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bundle ReportBundle size has no change ✅ |
9218612 to
4f0bf9a
Compare
|



Description
Skip Nvidia cards if we're looking for VAAPI devices. This is important for hybrid GPU laptops where the display may be connected through NVIDIA but rendering happens on Intel.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage