fix(linux/xdgportal): set variable rate capture#4624
Merged
ReenigneArcher merged 1 commit intoLizardByte:feat/linux/add-xdg-portal-grabfrom Jan 25, 2026
Merged
Conversation
The previous code was using fixed rate capture, but didn't set correctly, as the maxFramerate param governs the framerate on KWin. If unset, maxFramerate defaults to the host display refresh rate. However, even if set appropriately, KWin (but not mutter) would drop ~2fps per second on a 60fps stream constantly. If we instead set variable rate capture (0, 1) it resolves the FPS drop issue on KWin, and leaves our capture() function to handle the appropriate pacing.
d84cb6c to
deae19f
Compare
|
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/linux/add-xdg-portal-grab #4624 +/- ##
==================================================================
+ Coverage 13.34% 15.17% +1.83%
==================================================================
Files 69 95 +26
Lines 12623 19715 +7092
Branches 5947 9072 +3125
==================================================================
+ Hits 1684 2992 +1308
- Misses 10437 13220 +2783
- Partials 502 3503 +3001
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b63e1af
into
LizardByte:feat/linux/add-xdg-portal-grab
53 of 54 checks passed
ReenigneArcher
pushed a commit
that referenced
this pull request
Jan 27, 2026
ReenigneArcher
pushed a commit
that referenced
this pull request
Jan 30, 2026
ReenigneArcher
pushed a commit
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The previous code was using fixed rate capture, but didn't set correctly, as the maxFramerate param governs the framerate on KWin. If unset, maxFramerate defaults to the host display refresh rate. However, even if set appropriately, KWin (but not mutter) would drop ~2fps per second on a 60fps stream constantly.
If we instead set variable rate capture (0, 1) it resolves the FPS drop issue on KWin, and leaves our capture() function to handle the appropriate pacing.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage