Skip to content

fix(linux): install vendor preset for sunshine-kms service#4626

Merged
ReenigneArcher merged 1 commit intoLizardByte:feat/linux/add-xdg-portal-grabfrom
psyke83:xdg_servicepreset
Jan 26, 2026
Merged

fix(linux): install vendor preset for sunshine-kms service#4626
ReenigneArcher merged 1 commit intoLizardByte:feat/linux/add-xdg-portal-grabfrom
psyke83:xdg_servicepreset

Conversation

@psyke83
Copy link
Contributor

@psyke83 psyke83 commented Jan 25, 2026

Description

  • Install vendor preset so that sunshine-kms will default to disabled
  • Remove kms service from flatpak and AppImage (as it can't work)
  • Small documentation cleanups

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher added this to the xdg portal grab milestone Jan 25, 2026
@psyke83 psyke83 force-pushed the xdg_servicepreset branch 2 times, most recently from ca9ca43 to a2aa51a Compare January 25, 2026 02:49
@psyke83 psyke83 marked this pull request as ready for review January 25, 2026 02:49
@ReenigneArcher ReenigneArcher changed the title linux: install vendor preset for sunshine-kms service, flatpak fix fix(linux): install vendor preset for sunshine-kms service, flatpak fix Jan 25, 2026
ReenigneArcher

This comment was marked as resolved.

@psyke83

This comment was marked as resolved.

@psyke83
Copy link
Contributor Author

psyke83 commented Jan 26, 2026

In my opinion, the Flatpak instructions for KMS should be removed from the docs and packaging/linux/dev.lizardbyte.app.Sunshine.metainfo.xml. It's telling users basically to run as root, which seems risky even when you acknowledge it's sandboxed.

Edit: also, to clarify, you cannot install a service vendor preset to any folder in the user's /home that systemd will recognize. That's another reason why the KMS service is not a good idea to install in this case, as both services will default to enabled and thus may conflict in unpredictable ways.

I also investigated the AppImage "install" behaviour: Ubuntu 25.10's default AppArmor policy blocks setuid from being performed in a fusermount3 fs (which is used by AppImage), so there's no point in trying to install a kms service & preset for that case as well, since we can't even set the cap_sys_admin capability needed for the KMS service.

Will I update the PR with these conclusions in mind? I can keep the lines in the AppArmor scripts, but they won't work unless/until a workaround is devised for the AppArmor policy, which may never happen.

@ReenigneArcher

This comment was marked as resolved.

* Install vendor preset so that sunshine-kms will default to disabled
* Remove kms service from flatpak and AppImage (as it can't work)
* Small documentation cleanups
@psyke83 psyke83 changed the title fix(linux): install vendor preset for sunshine-kms service, flatpak fix fix(linux): install vendor preset for sunshine-kms service Jan 26, 2026
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 26, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.10%. Comparing base (b63e1af) to head (014c1ae).
⚠️ Report is 1 commits behind head on feat/linux/add-xdg-portal-grab.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           feat/linux/add-xdg-portal-grab    #4626      +/-   ##
==================================================================
+ Coverage                           14.81%   15.10%   +0.28%     
==================================================================
  Files                                  95       95              
  Lines                               20099    19715     -384     
  Branches                             9401     9072     -329     
==================================================================
  Hits                                 2977     2977              
+ Misses                              15985    15049     -936     
- Partials                             1137     1689     +552     
Flag Coverage Δ
Archlinux 11.09% <ø> (+0.01%) ⬆️
FreeBSD-14.3-amd64 13.24% <ø> (+0.02%) ⬆️
Homebrew-ubuntu-22.04 13.33% <ø> (ø)
Linux-AppImage 11.49% <ø> (+0.01%) ⬆️
Windows-AMD64 13.44% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 36 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit e1ad071 into LizardByte:feat/linux/add-xdg-portal-grab Jan 26, 2026
52 of 54 checks passed
@psyke83 psyke83 deleted the xdg_servicepreset branch February 15, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants