fix(linux): install vendor preset for sunshine-kms service#4626
Conversation
7b91016 to
3311fa3
Compare
ca9ca43 to
a2aa51a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
In my opinion, the Flatpak instructions for KMS should be removed from the docs and packaging/linux/dev.lizardbyte.app.Sunshine.metainfo.xml. It's telling users basically to run as root, which seems risky even when you acknowledge it's sandboxed. Edit: also, to clarify, you cannot install a service vendor preset to any folder in the user's /home that systemd will recognize. That's another reason why the KMS service is not a good idea to install in this case, as both services will default to enabled and thus may conflict in unpredictable ways. I also investigated the AppImage "install" behaviour: Ubuntu 25.10's default AppArmor policy blocks setuid from being performed in a fusermount3 fs (which is used by AppImage), so there's no point in trying to install a kms service & preset for that case as well, since we can't even set the cap_sys_admin capability needed for the KMS service. Will I update the PR with these conclusions in mind? I can keep the lines in the AppArmor scripts, but they won't work unless/until a workaround is devised for the AppArmor policy, which may never happen. |
This comment was marked as resolved.
This comment was marked as resolved.
* Install vendor preset so that sunshine-kms will default to disabled * Remove kms service from flatpak and AppImage (as it can't work) * Small documentation cleanups
a2aa51a to
014c1ae
Compare
|
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/linux/add-xdg-portal-grab #4626 +/- ##
==================================================================
+ Coverage 14.81% 15.10% +0.28%
==================================================================
Files 95 95
Lines 20099 19715 -384
Branches 9401 9072 -329
==================================================================
Hits 2977 2977
+ Misses 15985 15049 -936
- Partials 1137 1689 +552
Flags with carried forward coverage won't be shown. Click here to find out more. |
e1ad071
into
LizardByte:feat/linux/add-xdg-portal-grab



Description
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage