Skip to content

fix(linux): update systemd service units#4712

Merged
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
psyke83:systemd_update
Feb 13, 2026
Merged

fix(linux): update systemd service units#4712
ReenigneArcher merged 1 commit intoLizardByte:masterfrom
psyke83:systemd_update

Conversation

@psyke83
Copy link
Contributor

@psyke83 psyke83 commented Feb 13, 2026

Description

  • xdg-desktop-autostart.target is not used by vanilla GNOME sessions, so use graphical-session.target as the service enablement dependency.
  • Specify graphical-session.target, xdg-desktop-autostart.target and xdg-desktop-portal.service (unprivileged) to run before Sunshine, but leave as weak ordering hints by only specifying via the After unit fields.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

* xdg-desktop-autostart.target is not used by vanilla GNOME sessions,
  so use graphical-session.target as the service enablement dependency.
* Specify graphical-session.target, xdg-desktop-autostart.target and
  xdg-desktop-portal.service (unprivileged) to run before Sunshine,
  but leave as weak ordering hints by only specifying via the After unit
  fields.
@psyke83 psyke83 marked this pull request as ready for review February 13, 2026 01:04
@sonarqubecloud
Copy link

@psyke83
Copy link
Contributor Author

psyke83 commented Feb 13, 2026

A change that could be made in the case of the unprivileged service is to add:

[Unit]
Wants = xdg-desktop-portal.service

This would set up a weak dependency, so if the service exists on the system but was not scheduled to start, it would be started. XDG Desktop Portal needs this, but the unprivileged user service can also be used for x11 and wlroots capture, so I don't think we should assume it to be a requirement. Users may have deliberately disabled this service and may not appreciate Sunshine starting it, so I don't recommend setting this.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.52%. Comparing base (9ba2757) to head (b15529e).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4712      +/-   ##
==========================================
- Coverage   15.53%   15.52%   -0.01%     
==========================================
  Files          97       97              
  Lines       20476    20476              
  Branches     9400     9400              
==========================================
- Hits         3181     3179       -2     
+ Misses      16065    13660    -2405     
- Partials     1230     3637    +2407     
Flag Coverage Δ
Archlinux 11.19% <ø> (ø)
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.22% <ø> (-0.02%) ⬇️
Homebrew-ubuntu-22.04 13.42% <ø> (ø)
Linux-AppImage 11.60% <ø> (ø)
Windows-AMD64 13.49% <ø> (ø)
Windows-ARM64 12.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 47 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit f442ff8 into LizardByte:master Feb 13, 2026
56 of 57 checks passed
@psyke83 psyke83 deleted the systemd_update branch February 15, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants