GH-686 Limits on rate-pack values

[dnwiebe]

Note

Implements configurable limits for rate packs and updates schema, validation, and tests accordingly.

• Adds new rate_pack_limits config with parsing/validation in PersistentConfigurationReal; provides PersistentConfigurationInvalid and a factory
• DB: bumps CURRENT_SCHEMA_VERSION to 12; new migration 11→12 inserts default rate_pack_limits; DbInitializer/null DAO seed defaults
• Accountant: computes total_charge once and logs explicit wei amounts; updates related tests
• Tests/integration: larger networks/timeouts; switch HTTP checks to www.testingmcafeesites.com where applicable; improve bookkeeping assertions; add Docker network create retries; adjust rate-pack test values to wei scale
• Misc: enable time crate local-offset; minor gossip/dot-graph API tweaks and AccessibleGossipRecord Display; small bootstrapper/test renames; add SWEEP.md and minor .gitignore entry

^{Written by Cursor Bugbot for commit db8d8f3. This will update automatically on new commits. Configure here.}

[czarte]

I am still uncertain, this will protect the MASQ Foundation network, because if someone want's to set rate-pack below the limit, it is just one change and cargo build away from doing so and network does not even aknowledge this. I woud like to propose: make an debut_handler rule, that if the debuting node is in standard, or originate-only mode, and have rate pack below (or above) the limits, his debut is dropped on the flor

[kauri-hero]

Hey @dnwiebe @czarte - I agree with @czarte comments to add this additional checking in the handlers to ensure Nodes don't have rate-packs outside of the defined limits now, and can be done without too much additional work.

This will cover older versions of Node joining network with rates outside the hard-coded limits

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[cursor]

Two test assertions commented out reducing test coverage

Medium Severity

The test function data_can_be_routed_using_different_min_hops has two assertions commented out for Hops::OneHop and Hops::TwoHops, leaving only Hops::SixHops tested. While there's a comment mentioning timeout issues, commenting out tests reduces coverage significantly. This appears to be debugging code that was accidentally committed rather than a proper fix for the flaky test.