MDEV-36444: Add CREATE_OPTIONS column to I_S.COLUMNS and I_S.STATISTICS#4618
Open
abhishek593 wants to merge 5 commits intoMariaDB:mainfrom
Open
MDEV-36444: Add CREATE_OPTIONS column to I_S.COLUMNS and I_S.STATISTICS#4618abhishek593 wants to merge 5 commits intoMariaDB:mainfrom
abhishek593 wants to merge 5 commits intoMariaDB:mainfrom
Conversation
gkodinov
added
the
External Contribution
vuvova
requested changes
Feb 12, 2026
Member
vuvova
left a comment
vuvova
left a comment
There was a problem hiding this comment.
see comments inline. And please rebase on top of the main branch
sql/sql_show.cc
Outdated
Comment on lines
6653
to
6655
| char option_buff[512]; | ||
| String str(option_buff, sizeof(option_buff), system_charset_info); | ||
| str.length(0); |
sql/sql_show.cc
Outdated
| table->field[24]->set_notnull(); | ||
| } | ||
| else | ||
| table->field[24]->set_null(); |
Member
There was a problem hiding this comment.
I'm not sure about it. NULL generally means that there can be no create options, that it the concept is not applicable here. But it is not the case, the list is simply empty, I'd expect an empty string here, not NULL
Author
There was a problem hiding this comment.
Yeah, makes sense. I have updated the implementation to store an empty string.
| append_create_options(thd, &str, field->option_list, false, 0); | ||
| if (str.length()) | ||
| { | ||
| table->field[24]->store(str.ptr() + 1, str.length() - 1, cs); |
| } | ||
| else | ||
| table->field[17]->set_null(); | ||
| } |
sql/sql_show.cc
Outdated
| NULLABLE, OPEN_FRM_ONLY), // 21 | ||
| Column("IS_SYSTEM_TIME_PERIOD_START", Varchar(3), NOT_NULL, OPEN_FRM_ONLY), // 22 | ||
| Column("IS_SYSTEM_TIME_PERIOD_END", Varchar(3), NOT_NULL, OPEN_FRM_ONLY), // 23 | ||
| Column("CREATE_OPTIONS", Varchar(2048), NULLABLE, OPEN_FRM_ONLY), // 24 |
abhishek593
force-pushed
the
MDEV-36444
branch
from
34ae61b to
ce0c23f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes engine-defined column and index options in the I_S.COLUMNS and I_S.STATISTICS tables, respectively.
Key changes: