MDEV-39356: Server crashes when executing UPDATE ... FOR PORTION OF with a normal table#4954
Open
raghunandanbhat wants to merge 1 commit into11.8from
Open
MDEV-39356: Server crashes when executing UPDATE ... FOR PORTION OF with a normal table#4954raghunandanbhat wants to merge 1 commit into11.8from
UPDATE ... FOR PORTION OF with a normal table#4954raghunandanbhat wants to merge 1 commit into11.8from
Conversation
… with a normal table Problem: Executing an `UPDATE ... FOR PORTION OF` statement on a table without a defined period results in assertion failure. The code in `SELECT_LEX::period_setup_conds` attempts to compare a NULL period name identifier using `streq()`, which triggers the assertion in `strnncoll` funtion. Fix: Replace `streq` with `streq_safe` in `SELECT_LEX::period_setup_conds` to handle NULL pointers safely via an early-exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes MDEV-39356
Problem:
Executing an
UPDATE ... FOR PORTION OFstatement on a table without a defined period results in assertion failure. The code inSELECT_LEX::period_setup_condsattempts to compare a NULL period name identifier usingstreq(), which triggers the assertion instrnncollfuntion.Fix:
Replace
streqwithstreq_safeinSELECT_LEX::period_setup_condsto handle NULL pointers safely via an early-exit.