add type annotations to helm operator values#34775
Merged
jubrad merged 1 commit intoMaterializeInc:mainfrom Jan 29, 2026
Merged
add type annotations to helm operator values#34775jubrad merged 1 commit intoMaterializeInc:mainfrom
jubrad merged 1 commit intoMaterializeInc:mainfrom
Conversation
This will let downstream consumers of the value descriptions have better understanding of the types involved and auto-generate code.
jubrad
force-pushed
the
helm-type-annotations
branch
from
a56d47e to
5ea6d00
Compare
alex-hunt-materialize
approved these changes
Jan 29, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will let downstream consumers of the value
descriptions have better understanding of the types involved and auto-generate code.
There's one annoying thing here where, if you set a notationType it alters the way defaults are presented and they must be specified in the doc comments. I'll see if I can upstream a fix for that, but I don't think it's a huge issue until then.