[repr types] Convert ColumnKnowledge transform#34788
Merged
mgree merged 2 commits intoMaterializeInc:mainfrom Jan 28, 2026
Merged
[repr types] Convert ColumnKnowledge transform#34788mgree merged 2 commits intoMaterializeInc:mainfrom
mgree merged 2 commits intoMaterializeInc:mainfrom
Conversation
mgree
added
A-sql
ggevay
added a commit
that referenced
this pull request
Jan 29, 2026
Revert "[repr types] Convert ColumnKnowledge transform (#34788)"
5 tasks
mgree
added a commit
that referenced
this pull request
Feb 9, 2026
#34858 reverted #34788, due to a variety of panics in a nightly run. This PR adds the failures from those panics to an SLT file, for regression testing in a rewrite of the original PR. ### Motivation * This PR introduces regression tests for a recognized bug. MaterializeInc/database-issues#10045 MaterializeInc/database-issues#10046 MaterializeInc/database-issues#10052
mgree
added a commit
to mgree/materialize
that referenced
this pull request
Feb 9, 2026
…alizeInc#34905) MaterializeInc#34858 reverted MaterializeInc#34788, due to a variety of panics in a nightly run. This PR adds the failures from those panics to an SLT file, for regression testing in a rewrite of the original PR. ### Motivation * This PR introduces regression tests for a recognized bug. MaterializeInc/database-issues#10045 MaterializeInc/database-issues#10046 MaterializeInc/database-issues#10052
5 tasks
patrickwwbutler
pushed a commit
to patrickwwbutler/materialize
that referenced
this pull request
Feb 19, 2026
…alizeInc#34905) MaterializeInc#34858 reverted MaterializeInc#34788, due to a variety of panics in a nightly run. This PR adds the failures from those panics to an SLT file, for regression testing in a rewrite of the original PR. ### Motivation * This PR introduces regression tests for a recognized bug. MaterializeInc/database-issues#10045 MaterializeInc/database-issues#10046 MaterializeInc/database-issues#10052
patrickwwbutler
pushed a commit
to patrickwwbutler/materialize
that referenced
this pull request
Feb 19, 2026
…alizeInc#34905) MaterializeInc#34858 reverted MaterializeInc#34788, due to a variety of panics in a nightly run. This PR adds the failures from those panics to an SLT file, for regression testing in a rewrite of the original PR. ### Motivation * This PR introduces regression tests for a recognized bug. MaterializeInc/database-issues#10045 MaterializeInc/database-issues#10046 MaterializeInc/database-issues#10052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change ColumnKnowledge to use repr types.
Motivation
https://github.com/MaterializeInc/database-issues/issues/10016#issuecomment-3779135166
design doc: MIR typechecking using representation types #27239
Tips for reviewer
We can drop the cases of the if because they cannot occur---
ReprScalarTypes don't have meaningful modifiers.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.