Skip to content

iceberg: s3tables region limit dyncfg#34809

Merged
DAlperin merged 1 commit intoMaterializeInc:mainfrom
DAlperin:dov/s3tables-region-limit-dyncfg
Jan 26, 2026
Merged

iceberg: s3tables region limit dyncfg#34809
DAlperin merged 1 commit intoMaterializeInc:mainfrom
DAlperin:dov/s3tables-region-limit-dyncfg

Conversation

@DAlperin
Copy link
Member

Use a dyncfg to decide whether to enforce the region check

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@DAlperin DAlperin requested review from a team as code owners January 23, 2026 23:24
@DAlperin DAlperin requested a review from SangJunBak January 23, 2026 23:24
Use a dyncfg to decide whether to enforce the region check
@DAlperin DAlperin force-pushed the dov/s3tables-region-limit-dyncfg branch from 1a1fb23 to ad4b64b Compare January 23, 2026 23:31
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation? Why is it always off in CI?

@DAlperin
Copy link
Member Author

@def- difference in behavior between cloud and self managed. Off by default because I don't want it clashing with minios made up regions in CI, but there is an explicit test covering it in test/aws

@DAlperin DAlperin merged commit 15cdcb4 into MaterializeInc:main Jan 26, 2026
129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants