fix: fallback to recommendedQuote when selectedQuote is stale#8154
Merged
fix: fallback to recommendedQuote when selectedQuote is stale#8154
Conversation
GeorgeGkas
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixing a bug which causes the UI to get a nonexistent
activeQuoteon refresh. This updates the selector so it checks whether theselectedQuoteexists in the sorted quotes list first, and falls back on therecommendedQuoteotherwiseReferences
Checklist
Note
Low Risk
Small, well-tested change to quote selection logic; primary risk is minor behavior change in how
activeQuoteis chosen when quotes refresh.Overview
Fixes stale quote selection by updating
selectActiveQuote(used byselectBridgeQuotes) to only returnselectedQuoteif itsrequestIdstill exists insortedQuotes, otherwise falling back to therecommendedQuote.Updates unit tests to cover both the valid-selected-quote case and the stale-selected-quote fallback, and adds a changelog entry plus minor JSDoc punctuation/clarifications in
QuoteMetadata.Written by Cursor Bugbot for commit 517219a. This will update automatically on new commits. Configure here.