Conversation
GuillaumeRx
left a comment
There was a problem hiding this comment.
If the changes contains a breaking change please release a major version
7631db4 to
7a887bb
Compare
Resolve merge conflicts with main to unblock PR #8199. Made-with: Cursor
a9a4531 to
b693e85
Compare
b693e85 to
d2d92a4
Compare
4910fb6 to
85f9aa8
Compare
e2398ff to
7bdfb08
Compare
…assets-controller@2.3.1 Include these packages in Release 864.0.0-1 to avoid duplicate assets-controllers copies in the client bundle.
- bridge-controller, transaction-pay-controller: ^2.3.0 → ^2.3.1 for assets-controller - transaction-pay-controller: ^69.1.0 → ^69.1.1 for bridge-controller - bridge-status-controller: ^69.1.0 → ^69.1.1 for bridge-controller
…oller CHANGELOG Remove unrelated chore/fix entries that were accidentally added to the Unreleased section during a rebase. These entries belong to earlier releases and are not part of the release/864.0.0-1 scope.
7bdfb08 to
46a6393
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
- Remove trailing blank lines from 7 CHANGELOGs introduced during rebase conflict resolution (Prettier violations) - Merge duplicate [17.0.0] sections in transaction-pay-controller CHANGELOG into a single entry Made-with: Cursor
- bridge-status-controller: add bridge-controller ^69.1.0 → ^69.1.1 - transaction-pay-controller: add assets-controller ^2.3.0 → ^2.3.1 and bridge-controller ^69.1.0 → ^69.1.1 Made-with: Cursor
The changelog check requires entries linked to the current PR in the Unreleased section. Move the #8199 bump entries there and keep the remaining entries in the [17.0.0] released section. Made-with: Cursor
| "@metamask/assets-controller": "^2.3.0", | ||
| "@metamask/assets-controllers": "^100.2.1", | ||
| "@metamask/assets-controller": "^2.3.1", | ||
| "@metamask/assets-controllers": "^101.0.0", |
There was a problem hiding this comment.
Sorry to be a pain in an already very long-winded PR, but I think the expectation is that if a dependency has a major change, we should release this package too (same as bridge-controller).
GuillaumeRx
left a comment
There was a problem hiding this comment.
- The branch name is not standard and reflects to an already released version, same as the PR title
- The root
package.jsonversion hasn't been bumped
|
@jeremy-consensys I’m closing this PR since other releases have gone out ahead of it, and I’m currently preparing a release for the package you’re trying to release. |

Explanation
Release
@metamask/assets-controllersv100.3.0 — adds Stable network (chain 988) support.This is a scoped release for just
assets-controllersand its direct dependents. Changes included from#8185:
Dependent packages bumped to consume the new
assets-controllersversion:@metamask/assets-controller@metamask/bridge-controller@metamask/transaction-pay-controllerReferences
release/864.0.0Checklist
changed
changes in this PR and have
prepared draft pull requests for clients and consumer packages to resolve them
Note
Medium Risk
Primarily version/changelog updates, but it pulls in
@metamask/assets-controllers@101.0.0which includes breaking type renames and new chain support that could impact downstream builds/runtime if assumptions changed.Overview
Publishes a scoped release by bumping
@metamask/assets-controllersto101.0.0(adds Stable network/chain 988 support and exposes additional controller messenger actions per changelog).Updates direct dependents (
@metamask/assets-controller,@metamask/bridge-controller,@metamask/bridge-status-controller,@metamask/transaction-pay-controller) to consume the new versions, and refreshes package versions/changelogs plusyarn.lockaccordingly.Written by Cursor Bugbot for commit 8190e4d. This will update automatically on new commits. Configure here.