-
-
Notifications
You must be signed in to change notification settings - Fork 274
feat: add accountOverride to override default recipient or delegator for MM Pay transactions #8454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpuri
wants to merge
21
commits into
main
Choose a base branch
from
acc_override_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5bfa16c
feat: add accountOverride to override default recipient or delegator …
jpuri 1d0bce3
update
jpuri 7f9ce88
update
jpuri a969dd0
merge
jpuri f6a4071
Merge branch 'main' into acc_override_support
jpuri 7a28240
update
jpuri dae645e
Merge branch 'acc_override_support' of https://github.com/MetaMask/co…
jpuri db25703
update
jpuri 868b17d
update
jpuri 68f6ac3
update
jpuri f83bf0f
update
jpuri bd9f3a0
update
jpuri 1b7f538
update
jpuri 45a11d7
update
jpuri 7c350b3
Merge branch 'main' into acc_override_support
jpuri 7e3d54f
Merge branch 'main' into acc_override_support
jpuri 0b893bb
update
jpuri ef7089e
Merge branch 'acc_override_support' of https://github.com/MetaMask/co…
jpuri d6d0050
Merge branch 'main' into acc_override_support
jpuri 350ff2c
update
jpuri 2a0467b
Merge branch 'acc_override_support' of https://github.com/MetaMask/co…
jpuri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,6 +100,13 @@ export type TransactionConfig = { | |
| * go back to that account rather than the EOA. | ||
| */ | ||
| refundTo?: Hex; | ||
|
|
||
| /** | ||
| * Optional address to override the default account used by the transaction. | ||
| * When `isPostQuote` is true, used as the recipient of the MM Pay transfer. | ||
| * When `isPostQuote` is false, used as the delegator for the transaction, it provides the funds and pays for gas. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Slightly ambigious as the |
||
| */ | ||
| accountOverride?: Hex; | ||
| }; | ||
|
|
||
| /** Callback to update transaction config. */ | ||
|
|
@@ -183,6 +190,13 @@ export type TransactionData = { | |
| */ | ||
| refundTo?: Hex; | ||
|
|
||
| /** | ||
| * Optional address to override the default account used by the transaction. | ||
| * When `isPostQuote` is true, used as the recipient of the MM Pay transfer. | ||
| * When `isPostQuote` is false, used as the delegator for the transaction, it provides the funds and pays for gas. | ||
| */ | ||
| accountOverride?: Hex; | ||
|
|
||
| /** | ||
| * Token selected for the transaction. | ||
| * - For standard flows (isPostQuote=false): This is the SOURCE/payment token | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.